Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix/no-room-alert: 존재하지 않는 방에 참가 시 alert를 안해주던 버그 고침 #228

Merged
merged 1 commit into from
Dec 14, 2023
Merged

hotfix/no-room-alert: 존재하지 않는 방에 참가 시 alert를 안해주던 버그 고침 #228

merged 1 commit into from
Dec 14, 2023

Conversation

kiuuon
Copy link
Collaborator

@kiuuon kiuuon commented Dec 14, 2023

Checklist

  • Code Review: 작성한 코드를 다시 한 번 꼼꼼이 확인했나요?
  • Testing: 앱이 잘 구동되는지 개발한 기능이 문제 없이 작동하는지 확인했나요?

Description

joinRoom.ts 에서 throw error를 안해줘서 존재하지 않는 방에 참가 시 alert를 안해주던 버그를 고쳤습니다.

Changes Made

Extra Comments

Demo

@kiuuon
fix: 존재하지 않은 방에 참가 시 alert
bbf28bc 
throw error를 안해줘서 alert가 안됬던 버그를 고쳤습니다.
@kiuuon kiuuon requested a review from glowisn December 14, 2023 05:09
@kiuuon kiuuon self-assigned this Dec 14, 2023
glowisn
glowisn approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@glowisn glowisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GODLIKE

@kiuuon kiuuon merged commit 4faf3de into develop Dec 14, 2023
1 check passed
@vimkim vimkim deleted the hotfix/no-room-alert branch February 5, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glowisn glowisn glowisn approved these changes

Assignees

@kiuuon kiuuon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiuuon @glowisn