Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

워크플로우 오류 수정 #67

Merged
merged 2 commits into from
Nov 14, 2023
Merged

워크플로우 오류 수정 #67

merged 2 commits into from
Nov 14, 2023

Conversation

Taewan-P
Copy link
Member

워크플로우 실행중 발생하는 문제들을 해결했습니다.

  • Ktlint: 기존에는 변경사항에만 lint를 적용하였으나, 이미 추가된 파일에 대해서도 검사가 가능하게끔 필터 모드를 변경했습니다.
  • Firebase Deploy: Base64로 인코딩된 Keystore 파일을 디코딩하면서 생기는 오류를 수정하였습니다.

Taewan-P and others added 2 commits November 14, 2023 15:50
@Taewan-P @EunhoKang @ootr47
fix: Ktlint 필터링 모드 변경
1becbe3 
Co-Authored-By: EunhoKang <[email protected]>
Co-Authored-By: ootr47 <[email protected]>
@Taewan-P @EunhoKang @ootr47
fix: Keystore base64 디코딩 오류 수정
85c0e44 
Co-Authored-By: EunhoKang <[email protected]>
Co-Authored-By: ootr47 <[email protected]>
@github-actions github-actions bot added the infra CI/CD, 환경 설정 label Nov 14, 2023
ootr47
ootr47 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@ootr47 ootr47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EunhoKang
EunhoKang approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@EunhoKang EunhoKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ootr47 ootr47 merged commit bc397b6 into develop Nov 14, 2023
1 check passed
@Taewan-P Taewan-P linked an issue Nov 14, 2023 that may be closed by this pull request
워크플로우를 구축한다. #58
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EunhoKang EunhoKang EunhoKang approved these changes

@ootr47 ootr47 ootr47 approved these changes

Assignees
No one assigned
Labels
infra CI/CD, 환경 설정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

워크플로우를 구축한다.
3 participants
@Taewan-P @EunhoKang @ootr47