Skip to content

Commit

Permalink
Dependecy real
Browse files Browse the repository at this point in the history
  • Loading branch information
bonnie57 committed Nov 20, 2024
1 parent 704fe66 commit a5aafca
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/publish-package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ jobs:
build-test-publish,
print_version_to_publish,
check_if_version_is_valid_for_branch,
fetch_latest_version,
]
# Skip this job if core-sdk doesn't need to be published
# and the event triggering the workflow is a push
Expand All @@ -232,6 +233,7 @@ jobs:
with:
tag_name: core-sdk@${{ needs.print_version_to_publish.outputs.core_sdk_version_to_be_published }}
is_core_sdk: true
last_tag: ${{ needs.fetch_latest_version.outputs.CORE_SDK_LATEST_VERSION }}

send_slack_notif-core-sdk:
needs: [print_version_to_publish, create-release-core-sdk]
Expand Down Expand Up @@ -259,6 +261,7 @@ jobs:
with:
tag_name: react-sdk@${{ needs.print_version_to_publish.outputs.react_sdk_version_to_be_published }}
is_core_sdk: false
last_tag: ${{ needs.fetch_latest_version.outputs.REACT_SDK_LATEST_VERSION }}

send_slack_notif-react-sdk:
needs: [print_version_to_publish, create-release-react-sdk]
Expand Down
15 changes: 5 additions & 10 deletions .github/workflows/reusable-create-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ on:
type: boolean
description: "Flag to indicate if this is a core SDK release"
required: true
last_tag:
type: string
description: "last tag name"
required: true

permissions:
contents: write
Expand All @@ -23,15 +27,6 @@ jobs:
- name: Checkout
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5

- name: Retrieve Previous Tag Before Creating New Tag
id: get_previous_tag
run: |
git fetch --tags
# Get the last tag from the list of tags sorted by creation date
LATEST_TAG=$(git tag --sort=creatordate | tail -n1)
echo "The latest tag based on creation date is $LATEST_TAG"
echo "fromTag=$LATEST_TAG" >> $GITHUB_ENV
- name: Tag and Push
id: tag_and_push
run: |
Expand Down Expand Up @@ -61,7 +56,7 @@ jobs:
with:
configuration: ${{ env.config_file }}
toTag: ${{ inputs.tag_name}}
fromTag: ${{ env.fromTag }}
fromTag: ${{ inputs.last_tag}}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down

0 comments on commit a5aafca

Please sign in to comment.