Add GHA workflow #19
Open
Add GHA workflow #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonBazan
reviewed
Nov 7, 2022
| composer install | ||
| - name: Run tests and analytics | ||
| run: | | ||
| vendor/phpunit/phpunit/phpunit -c phpunit.xml Tests/ |
There was a problem hiding this comment.
We can simplify that to:
Suggested change
| vendor/phpunit/phpunit/phpunit -c phpunit.xml Tests/ | |
| vendor/bin/phpunit |
| coverage: ${{matrix.coverage}} # XDebug disabled | ||
| - name: Install composer dependencies | ||
| run: | | ||
| cp phpunit.xml.dist phpunit.xml |
There was a problem hiding this comment.
This line can be removed - PHPUnit looks for phpunit.xml.dist by default if phpunit.xml is not present.
| matrix: | ||
| php_version: [7.4, 8.0] | ||
| symfony: [4.4, 5] | ||
| coverage: [none, pcov] |
There was a problem hiding this comment.
I'd always install pcov. We can decide if we want to run coverage under certain conditions, but might as well be generated for each run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.