Skip to content

v1.0.0: remove deprecated options #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coolaj86 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

v1.0.0: remove deprecated options #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,6 @@ OPTIONS
--user <username> defaults to 'aj'
--workdir <dirpath> where the command runs, defaults to current directory

DEPRECATED (DO NOT USE)
--system alias of --daemon, for compatibility
--username alias of --user, for compatibility
--groupname alias of --group, for compatibility

EXAMPLES
caddy: serviceman add -- caddy run --envfile ./.env --config ./Caddyfile --adapter caddyfile
node: serviceman add --workdir . --name 'api' -- node ./server.js
Expand Down
62 changes: 0 additions & 62 deletions bin/serviceman
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,6 @@ fn_add_help() { (
echo " --user <username> defaults to '$(id -u -n)'"
echo ' --workdir <dirpath> where the command runs, defaults to current directory'
echo ""
echo "DEPRECATED (DO NOT USE)"
echo " --system alias of --daemon, for compatibility"
echo " --username alias of --user, for compatibility"
echo " --groupname alias of --group, for compatibility"
echo ""
echo "EXAMPLES"
echo " caddy: serviceman add -- caddy run --envfile ./.env --config ./Caddyfile --adapter caddyfile"
echo " node: serviceman add --workdir . --name 'api' -- node ./server.js"
Expand Down Expand Up @@ -177,63 +172,6 @@ cmd_add() { (
;;
esac

# transitional
case "${b_arg}" in
-help)
echo "warn: -help should be --help"
b_arg='--help'
;;
-cap-net-bind | --cap-net-bind)
echo "warn: --cap-net-bind is now the default, use --no-cap-net-bind to disable"
b_arg='--no-cap-net-bind'
;;
-dryrun)
echo "warn: -dryrun should be --dryrun"
b_arg='--dryrun'
;;
-force)
echo "warn: -force should be --force"
b_arg='--force'
;;
-system | --system)
echo "warn: --system is now --daemon"
b_arg='--daemon'
;;
-name)
echo "warn: -name should be --name"
b_arg='--name'
;;
-desc)
echo "warn: -desc should be --desc"
b_arg='--desc'
;;
-groupname | --groupname)
echo "warn: --groupname should be --group"
b_arg='--group'
;;
-rdns)
echo "warn: -rdns should be --rdns"
b_arg='--rdns'
;;
-title)
echo "warn: -title should be --title"
b_arg='--title'
;;
-url)
echo "warn: -url should be --url"
b_arg='--url'
;;
-user | -username | --username)
echo "warn: --username should be --user"
b_arg='--user'
;;
-workdir)
echo "warn: -workdir should be --workdir"
b_arg='--workdir'
;;
*) ;;
esac

case "${b_arg}" in
--)
break
Expand Down