fix: treat type parameter changes in base class as dedicated change #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmil
requested review from
adamgic,
fabiomcarneiro,
fwagner,
klink182 and
marafelismino
as code owners
adamgic
reviewed
Jul 28, 2025
Co-authored-by: Adam <adamgic@wp.pl>
adamgic
reviewed
Jul 28, 2025
adamgic
approved these changes
Jul 28, 2025
fabiomcarneiro
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the type parameter(s) of a base class currently leads to two detected changes:
This can be confusing. So this PR introduces a new type of change: super type change
The mentioned change in type parameters now leads to one super type change (breaking)
fixes #224
Type of Change