Tab5 mmc #264
Tab5 mmc #264
Conversation
Added an empty display function with a default parameter.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7564aee6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Serial.println("Saving values into NVS"); | ||
| err = ESP_OK; | ||
| err = nvsHandle->set_item("x0", calData[0]); | ||
| err |= nvsHandle->set_item("x1", calData[1]); | ||
| err |= nvsHandle->set_item("y0", calData[2]); |
There was a problem hiding this comment.
The new calibration path writes values with set_item(...) but never calls nvsHandle->commit(). On ESP-IDF, NVS writes are buffered until commit; without it the calibration data is lost on reboot, so users will be prompted to re‑calibrate every power cycle. Add a commit() after the last set_item (and handle any error) to persist the values.
Useful? React with 👍 / 👎.
No description provided.