Fix typos in IDA iterative solvers, add tests #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple typos in the preconditioner wrappers for IDA:
aux_data.r_vec->aux_data.rvec_tmpto be consistent withIDA_dataprec_solvefn.evaluate()call was missingyp_tmpspbcgas a linear solver, but code expectedspbcgsI also added
test_iterative.pywhich uses the Robertson problem to test all three iterative solvers. I had to skip these tests for extended-precision builds because I usednp.linalg.solvewhich cannot handlelongdouble.