make video posts which are quote posts show up in video feeds #7534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Jan 22, 2025
|
apologies, this would need a rebase |
kaytwo
force-pushed
the
main
branch
2 times, most recently
from
7f13745 to
b20da65
Compare
kaytwo
commented
Jan 23, 2025
| export function isVideoView( | ||
| v: unknown, | ||
| ): v is | ||
| | AppBskyEmbedVideo.View |
There was a problem hiding this comment.
This type refinement feels like it should convince ts that the returned value can only be one of these two types of view but judging by my lsp it didn’t seem to work in practice.
|
@gaearon PTAL, successfully rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Video posts are fundamentally
EmbedRecordWithMediawhereas plain video posts areEmbedVideo, the shape of the object and where the user's uploaded video exist within the post are different. This PR extracts the relevantEmbedVideowherever relevant and passes it to the renderer.Testing
Check this feed on live mobile / dev mobile / desktop: https://bsky.app/profile/feedtester.bsky.social/feed/videos
On desktop it's got 3 videos, on this branch on iOS it has 3 videos, on live it only shows 1 video (the non-quote-post one).