Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-report menu #7446

Merged
merged 10 commits into from
Jan 22, 2025
Merged

Post-report menu #7446

merged 10 commits into from
Jan 22, 2025

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Jan 13, 2025

Shows a menu offering to block and/or delete the conversation.

Simulator.Screen.Recording.-.iPhone.16.-.2025-01-13.at.21.56.56.mp4

Test plan

You might want to comment out the line that sends the report (ReportDialog.tsx:163)

  1. Test that the core functionality works (it blocks, it leaves)
  2. Check the handling of when API calls is slow or fails - it fetches the profile view for example (ReportDialog.tsx:75)
  3. Check web styles

@arcalinea arcalinea temporarily deployed to samuel/postreport - social-app PR #7446 January 13, 2025 22:06 — with Render Destroyed
Copy link

github-actions bot commented Jan 13, 2025

Old size New size Diff
6.96 MB 6.97 MB 6.22 KB (0.09%)

@gaearon
Copy link
Contributor

gaearon commented Jan 20, 2025

Block+delete doesn't seem to work until I refresh

Screenshot 2025-01-20 at 17 39 23

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesss

@arcalinea arcalinea temporarily deployed to samuel/postreport - social-app PR #7446 January 22, 2025 20:55 — with Render Destroyed
@gaearon gaearon merged commit 74bb657 into main Jan 22, 2025
7 checks passed
@gaearon gaearon deleted the samuel/postreport branch January 22, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants