MobX removal take 2 #5381
Merged
MobX removal take 2 #5381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
mary-ext
force-pushed
the
remove-mobx
branch
from
0b7d992
to
e238ab1
Compare
|
I've rebased this PR and #3942 |
|
Can you please rebase and also clarify the relationship between #3925 and this PR? |
|
will rebase again tomorrow since it's getting late, PR is a subset of Paul's, only containing the bits related to removing MobX. |
mary-ext
force-pushed
the
remove-mobx
branch
from
e238ab1
to
27c71ed
Compare
|
@gaearon should be ok to review now 👌 |
Merged
gaearon
approved these changes
Sep 24, 2024
|
Just fyi @gaearon I think we need to rm mobx from |
|
Gave this some testing across platforms, seems solid. Thank you for untangling this and bringing it up to date! |
estrattonbailey
added a commit
that referenced
this pull request
Sep 24, 2024
* origin/main: Remove image resizer (#5464) Remove `react-native-fs` (#5463) Revamp image editor (#5462) Revamp edit image alt text dialog (#5461) MobX removal take 2 (#5381) Edit self hosting copy (#5469) Automatically optimise SVG assets (#5467) [Share Extension] Update to support video (#5385) Revert change in FAB animation (#5465) Improvements to NSE (#4992) Don't use flex on inputs (#5458) Fix web splash (#5456) invert the fab animation, play a haptic (#4309) add sideborders to <ProfileHeaderLoading> (#4995) [Video] Flush low quality segments once focused (#5430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of #3925 (don't close/delete this branch yet)
Refactors the image functionality on the editor and removes remaining the MobX dependency completely. Worth noting that web-only image editor has been ripped out completely (too tangled in mutations which makes it infeasible to do in the same PR, we'll re-add this in a follow-up)
Image states are now immutable. Images are moved into a temporary path dedicated for the composer and they're purged upon closing the composer (IIRC asked @haileyok for where to place the
purgeTemporaryFilescall).Some manual checks
Web
Native (Android)
Untested, haven't dealt with Android Studio in a bit, have gotten around to wrangling with it. There hasn't been any differences between #3925 and this with regards to how the temporary files are dealt with, but extra verification wouldn't hurt
Image editing flow needs testing as well.
Native (iOS)
Untested, no iOS device.
Image editing flow needs testing as well.
Follow-ups
#3942 is required for pulling in the new cropper from #3925, as we're going to be importing a CSS file from the new package we'd be using for cropping functionality.