Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timeline appearance in browser on smartphone #5346

Closed
wants to merge 2 commits into from

Conversation

tomo-x7
Copy link

@tomo-x7 tomo-x7 commented Sep 14, 2024

If you view the timeline with the language setting set to Japanese in your smartphone browser, user posts with long handles and names look like this (probably all languages where the browser automatically does the wrapping without recognizing the space between words will be like this)
image
If the name and handle are short, it will look normal like this
image
If the language display is set to English, even if the name is in Japanese, it will be displayed correctly like this
image

@tomo-x7 tomo-x7 changed the title fix appearance fix timeline appearance in browser on smartphone Sep 14, 2024
@tomo-x7 tomo-x7 marked this pull request as draft September 14, 2024 16:35
@tomo-x7 tomo-x7 marked this pull request as ready for review September 14, 2024 16:59
@gaearon
Copy link
Contributor

gaearon commented Sep 14, 2024

Does this need the web-only condition?

@tomo-x7
Copy link
Author

tomo-x7 commented Sep 14, 2024

Does this need the web-only condition?

Sorry, I don't know.
However, I limited it to web only because native apps don't need to modify it and react native doesn't have whitespace property.

@surfdude29
Copy link
Contributor

See also #5322 by @quiple which I think is trying to fix the same issue

@tomo-x7
Copy link
Author

tomo-x7 commented Sep 14, 2024

Oh!
I had missed that.
Sorry to hear that but I hope his 5322 works out.
Should I close this PR?

@surfdude29
Copy link
Contributor

Oh!
I had missed that.
Sorry to hear that but I hope his 5322 works out.
Should I close this PR?

I don't know what the etiquette is for situations like this, and to be clear I wasn't meaning any criticism, I just thought it would be helpful to mention the other PR as they both seem to be tackling the same issue.

I would suggest leaving this open and let the Bluesky team decide what to do :)

@tomo-x7
Copy link
Author

tomo-x7 commented Sep 15, 2024

I don't know what the etiquette is for situations like this, and to be clear I wasn't meaning any criticism, I just thought it would be helpful to mention the other PR as they both seem to be tackling the same issue.

Sorry for the misunderstanding. I don't feel criticized at all and I appreciate you telling me.

I would suggest leaving this open and let the Bluesky team decide what to do :)

Okay, I will do that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants