Image open animation #5287
Draft
Image open animation #5287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Sep 12, 2024
| return ( | ||
| <Animated.View ref={containerRef} style={styles.container}> | ||
| {isLoading && ( | ||
| <ActivityIndicator size="small" color="#FFF" style={styles.loading} /> |
There was a problem hiding this comment.
Couldn't figure out how to make this guy work well, but it seems less important now anyway. Figured I'd just remove it. Maybe we can readd with a bit more thinking.
Or we can add some placeholder.
gaearon
commented
Sep 12, 2024
| @@ -143,14 +141,13 @@ const ImageItem = ({ | |||
| maximumZoomScale={maxZoomScale} | |||
| contentContainerStyle={styles.imageScrollContainer} | |||
| onScroll={scrollHandler}> | |||
| {(!loaded || !imageDimensions) && <ImageLoading />} | |||
gaearon
commented
Sep 12, 2024
| <ImageViewing | ||
| key={props.initialImageIndex} | ||
| {...props} | ||
| onLoad={() => { |
There was a problem hiding this comment.
This might be too conservative since it'll just get stuck if the network is slow. Maybe worth adding a safeguard timeout. Or it would require a bigger rework to integrate with the slider and dismiss gesture inside.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not perfect (in particular, there is no corresponding exit) but it kinda works.
Putting this out for initial testing. Needs testing on device!
The animation is disabled if you enable the Reduced Motion system setting.
iOS
ios.mov
Android
android.mov