make PDS table unique on host name #913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix old data that had dups on PDS host name
ericvolp12
reviewed
Jan 20, 2025
Comment on lines
+253
to
+261
| err = db.Exec("UPDATE users SET pds = ? WHERE pds = ?", minPDSId, xPDSId).Error | ||
| if err != nil { | ||
| return fmt.Errorf("failed to update user pds %d -> %d: %w", xPDSId, minPDSId, err) | ||
| } | ||
| err = db.Exec("UPDATE actor_infos SET pds = ? WHERE pds = ?", minPDSId, xPDSId).Error | ||
| if err != nil { | ||
| return fmt.Errorf("failed to update actor_infos pds %d -> %d: %w", xPDSId, minPDSId, err) | ||
| } | ||
| err = db.Exec("DELETE FROM pds WHERE id = ?", xPDSId).Error |
There was a problem hiding this comment.
Do we want to do these in a transaction?
There was a problem hiding this comment.
kinda? I put it effectively into relay 'boot code' before threads of work are started. I guess the bad case is multiple bigsky processes pointed at the same PostgreSQL, but I bet it handles that badly in many ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix old data that had dups on PDS host name