Feat: adds app.bsky.graph.defs#skeletonReasonSponsored lexicon. #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aendra-rininsland
added a commit
to aendra-rininsland/social-app
that referenced
this pull request
Jan 20, 2025
|
Marking as "ready" given this needs to be merged before bluesky-social/social-app#7518. |
bnewbold
reviewed
Jan 22, 2025
lexicons/app/bsky/feed/defs.json
Outdated
| "properties": { | ||
| "info": { | ||
| "type": "string", | ||
| "description": "Extended information about sponsored content, provided by the feed generator for transparency purposes." |
There was a problem hiding this comment.
Can probably hold off on changes until the social-app PR gets a reply, but quick notes:
- a description on the overall object clarifying that it existing at all means the feed item is sponsored content (we don't have good descriptions like this for
skeletonReasonRepostorskeletonReasonPin, but we should) - we are slowly but surely trying to lock down every
stringfield with amaxLengthto prevent shenanigans. maybe 2000 bytes (likefeedContext)?
I'd be interested in considering if this should eventually be an AT-URI field pointing at a "context" record of some type. We are thinking about a generic "annotation" / "more context" mechanism for things like labels. That is still speculative though, and this is an optional field so there is a transition path.
There was a problem hiding this comment.
Thanks for the feedback! I've added a description and a maxLength as requested in the meantime while waiting for a response on bluesky-social/social-app#7518.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3386.
I'm also working on a PR for bluesky-social/social-app to add UI for these. Creating this as a draft in the interim.