SCI: Remove the usage of NDEBUG

We don't define NDEBUG in release builds, but we have other means
of debugging in our common code, via debug levels

engines/sci/graphics/celobj32.cpp

@@ -105,9 +105,7 @@ void CelObj::deinit() {
 
 template<bool FLIP, typename READER>
 struct SCALER_NoScale {
-#ifndef NDEBUG
 	const byte *_rowEdge;
-#endif
 	const byte *_row;
 	READER _reader;
 	const int16 _lastIndex;
@@ -125,15 +123,11 @@ struct SCALER_NoScale {
 		_row = _reader.getRow(y - _sourceY);
 
 		if (FLIP) {
-#ifndef NDEBUG
 			_rowEdge = _row - 1;
-#endif
 			_row += _lastIndex - (x - _sourceX);
 			assert(_row > _rowEdge);
 		} else {
-#ifndef NDEBUG
 			_rowEdge = _row + _lastIndex + 1;
-#endif
 			_row += x - _sourceX;
 			assert(_row < _rowEdge);
 		}
@@ -152,10 +146,8 @@ struct SCALER_NoScale {
 
 template<bool FLIP, typename READER>
 struct SCALER_Scale {
-#ifndef NDEBUG
 	int16 _minX;
 	int16 _maxX;
-#endif
 	const byte *_row;
 	READER _reader;
 	// If _sourceBuffer is set, it contains the full (possibly scaled) source
@@ -167,18 +159,14 @@ struct SCALER_Scale {
 
 	SCALER_Scale(const CelObj &celObj, const Common::Rect &targetRect, const Common::Point &scaledPosition, const Ratio scaleX, const Ratio scaleY) :
 	_row(nullptr),
-#ifndef NDEBUG
 	_minX(targetRect.left),
 	_maxX(targetRect.right - 1),
-#endif
 	// The maximum width of the scaled object may not be as wide as the source
 	// data it requires if downscaling, so just always make the reader
 	// decompress an entire line of source data when scaling
 	_reader(celObj, celObj._width),
 	_sourceBuffer() {
-#ifndef NDEBUG
 		assert(_minX <= _maxX);
-#endif
 
 		// In order for scaling ratios to apply equally across objects that
 		// start at different positions on the screen (like the cels of a
@@ -316,27 +304,21 @@ int16 SCALER_Scale<FLIP, READER>::_valuesY[kCelScalerTableSize];
 
 struct READER_Uncompressed {
 private:
-#ifndef NDEBUG
 	int16 _sourceHeight;
-#endif
 	const byte *_pixels;
 	const int16 _sourceWidth;
 
 public:
 	READER_Uncompressed(const CelObj &celObj, const int16) :
-#ifndef NDEBUG
 	_sourceHeight(celObj._height),
-#endif
 	_sourceWidth(celObj._width) {
 		const SciSpan<const byte> resource = celObj.getResPointer();
 		const uint32 pixelsOffset = resource.getUint32SEAt(celObj._celHeaderOffset + 24);
 		const int32 numPixels = MIN<int32>(resource.size() - pixelsOffset, celObj._width * celObj._height);
 
 		if (numPixels < celObj._width * celObj._height) {
 			warning("%s is truncated", celObj._info.toString().c_str());
-#ifndef NDEBUG
 			_sourceHeight = numPixels / celObj._width;
-#endif
 		}
 
 		_pixels = resource.getUnsafeDataAt(pixelsOffset, numPixels);