tests: Update snapshot tests for Textual 0.77 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of Textual adds a key to the footer for opening the command palette. We could disable this, since it's taking up a bit of precious screen real estate, but one of the options in the command palette is a full list of keys bindings that can be opened in a side panel. That's useful enough to justify keeping this item, even if it means cutting off our own bindings. Signed-off-by: Matt Wozniski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
+ Coverage 92.98% 93.01% +0.02%
==========================================
Files 94 94
Lines 11445 11445
Branches 2114 2114
==========================================
+ Hits 10642 10645 +3
+ Misses 803 800 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pablogsal
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of Textual adds a key to the footer for opening the command palette. We could disable this, since it's taking up a bit of precious screen real estate, but one of the options in the command palette is a full list of keys bindings that can be opened in a side panel. That's useful enough to justify keeping this item, even if it means cutting off our own bindings.