Show Time Duration in Stats Modal #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 94 94
Lines 11420 11420
Branches 2094 2094
=======================================
Hits 10631 10631
Misses 789 789
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: RafaelWO <[email protected]>
RafaelWO
force-pushed
the
feature/show-time-duration
branch
from
c1e525d
to
061584b
Compare
pablogsal
approved these changes
Aug 9, 2024
|
Thanks for the PR @RafaelWO ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #646
Describe your changes
This PR adds the time duration to the stats modal (in
base.html) based on the existing values for start and end time.Testing performed
To test this feature I installed memray from source and generated a flamegraph on a sample file. Below is a screenshot of the stats modal including the time duration.
Additional context
n/a