tests: Skip snapshot tests if Textual is outdated #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have our test suite check the version of Textual and pytest-textual-snapshot that it's running with, and automatically disable the Textual snapshot tests if we can determine statically that they will go on to fail. This is a better experience for 3rd party package maintainers and simplifies our handling of Python versions that Textual has already dropped support for. This doesn't negatively affect our CI, since we keep our dependencies live at head in CI. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
skip_snapshot_tests_based_on_textual_version
branch
from
50393a4
to
12d8f38
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 93.05% 92.99% -0.07%
==========================================
Files 94 94
Lines 11420 11445 +25
Branches 2094 2114 +20
==========================================
+ Hits 10627 10643 +16
- Misses 793 802 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pablogsal
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have our test suite check the version of Textual and pytest-textual-snapshot that it's running with, and automatically disable the Textual snapshot tests if we can determine statically that they will go on to fail. This is a better experience for 3rd party package maintainers and simplifies our handling of Python versions that Textual has already dropped support for. This doesn't negatively affect our CI, since we keep our dependencies live at head in CI.
Closes #654