Retain inverted-ness when redrawing graph. #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
+ Coverage 92.55% 93.07% +0.52%
==========================================
Files 91 94 +3
Lines 11304 11420 +116
Branches 1581 2094 +513
==========================================
+ Hits 10462 10629 +167
+ Misses 837 791 -46
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Previously clicking the "Hide Irrelevant Frames" or "Hide Import System Frames" checkboxes would switch the flame graph back to icicle mode. Ensure we retain flame mode when the user has chosen it.
godlygeek
force-pushed
the
fix-change-filter
branch
from
fd79700
to
e0bdf68
Compare
godlygeek
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655.
Describe your changes
When the flamegraph is redrawn, keep the inversion from the previous graph, if it exists.
Testing performed
I opened a flamegraph and made sure that it worked :)