Fix debugger output parsing in attach command #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
==========================================
- Coverage 92.29% 92.12% -0.17%
==========================================
Files 91 91
Lines 10849 10850 +1
Branches 1498 1499 +1
==========================================
- Hits 10013 9996 -17
- Misses 834 851 +17
- Partials 2 3 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
When using lldb in macOS, the output of lldb is slighly different and we are not properly matching that is what we expect. To avoid having to rely on weird hacks to not detect the actual command we issue, filter the output to not contain the lines that have the debugger promt to only check against the actual debugger output. This simplifies the check and provides an easier way to do assert that we are in the situation we expect. Signed-off-by: Pablo Galindo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using lldb in macOS, the output of lldb is slighly different and we
are not properly matching that is what we expect. To avoid having to
rely on weird hacks to not detect the actual command we issue, filter
the output to not contain the lines that have the debugger promt to only
check against the actual debugger output. This simplifies the check and
provides an easier way to do assert that we are in the situation we
expect.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.