Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the memray attach callback into a module #459

Closed
wants to merge 5 commits into from
Closed

Move the memray attach callback into a module #459

wants to merge 5 commits into from

Commits on Sep 8, 2023

  1. Added --aggregate option to attach 

    Added --aggregate option which allows user to request aggregated mode for in-memory aggregation.

Signed-off-by: Ivona Stojanovic <[email protected]>
    @ivonastojanovic
    ivonastojanovic committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    2751eb4 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. fixup! Added --aggregate option to attach 

    Signed-off-by: Ivona Stojanovic <[email protected]>
    @ivonastojanovic
    ivonastojanovic committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    01f4121 View commit details
    Browse the repository at this point in the history

  2. Tests: Added --aggregate option to attach 

    Added a unit and an integration test for the --aggregate option. The unit test tests the case when --aggregate is given but --output is not. The --aggregate option is tested in the integration test.

Signed-off-by: Ivona Stojanovic <[email protected]>
    @ivonastojanovic
    ivonastojanovic committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3c5852e View commit details
    Browse the repository at this point in the history

  3. fixup! Tests: Added --aggregate option to attach

    @godlygeek
    godlygeek committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5a2cdef View commit details
    Browse the repository at this point in the history

  4. Move the memray attach callback into a module 

    Previously we were maintaining this as a string literal inside the
client-side `attach` code, but it's growing more complex, and we're
reaching the point where it would be advantageous to have it in a normal
module that linters and type checkers can analyze.

Signed-off-by: Matt Wozniski <[email protected]>
    @godlygeek
    godlygeek committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d47422d View commit details
    Browse the repository at this point in the history