Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Split docs building from linting #223

Closed

Conversation

godlygeek
Copy link
Contributor

This lays the groundwork for automatically uploading documentation when a release is cut.

Signed-off-by: Matt Wozniski [email protected]

@godlygeek godlygeek self-assigned this Oct 4, 2022
@godlygeek
Copy link
Contributor Author

This gets us 80% of the way there. On top of this, we should have an action that fires only when releases are published that publishes the github-pages artifact to the gh-pages branch using actions/pages-deploy - but I'm not sure how to test that right now, given that what's on main contains some staged documentation changes for the next release that we're not yet ready to publish.

@pablogsal
Copy link
Member

@godlygeek do you want to merge this PR as it is and work on the automation as a separate one?

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (a519a95) 91.72% compared to head (c181678) 91.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   91.72%   91.70%   -0.02%     
==========================================
  Files          90       90              
  Lines       10503    10503              
  Branches     1446     1446              
==========================================
- Hits         9634     9632       -2     
- Misses        866      868       +2     
  Partials        3        3              
Flag Coverage Δ
cpp 85.12% <ø> (-0.06%) ⬇️
python_and_cython 95.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godlygeek godlygeek force-pushed the publish_pages_automatically branch 3 times, most recently from 2748f85 to f8b6086 Compare August 1, 2023 21:14
This lays the groundwork for automatically uploading documentation when
a release is cut.

Signed-off-by: Matt Wozniski <[email protected]>
@godlygeek godlygeek force-pushed the publish_pages_automatically branch 4 times, most recently from a0b97f9 to 3b4b882 Compare August 1, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants