Skip coverage html generation in Alpine

There a bug either in the genhtml utility in Alpine or in coverage.py that trips over some categories that are in the dump file. We don't use these files in CI for anything so for now we should skip the html generation. Signed-off-by: Pablo Galindo <[email protected]>
bloomberg · Oct 23, 2024 · 32cd30d · 32cd30d
1 parent 9a4268f
commit 32cd30d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -72,6 +72,9 @@ jobs:
     container:
       image: alpine
       options: --cap-add=SYS_PTRACE
+    env:
+      # Coverage is kind of broken in Alpine
+      SKIP_COVERAGE_HTML: 1
     steps:
       - uses: actions/checkout@v4
       - name: Set up dependencies

diff --git a/Makefile b/Makefile
@@ -77,8 +77,10 @@ pycoverage:  ## Run the test suite, with Python code coverage
 		--cov-fail-under=90 \
 		--cov-append $(PYTEST_ARGS) \
 		tests
-	$(PYTHON) -m coverage lcov -i -o pycoverage.lcov
-	genhtml *coverage.lcov  --branch-coverage --output-directory memray-coverage $(GENHTMLOPTS)
+  if [ -z "$$SKIP_COVERAGE_HTML" ]; then \
+		$(PYTHON) -m coverage lcov -i -o pycoverage.lcov \
+  	genhtml *coverage.lcov  --branch-coverage --output-directory memray-coverage $(GENHTMLOPTS); \
+  fi
 
 .PHONY: valgrind
 valgrind:  ## Run valgrind, with the correct configuration

diff --git a/news/693.bugfix.rst b/news/693.bugfix.rst
@@ -0,0 +1 @@
+Fixed a bug that was causing tracking of runtime libraries that are part of the linker cache not work in macOS 15.