Don't use identity_cb for queries which aren't physical rep 8.0 #4865
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mohitkhullar <[email protected]>
roborivers
suggested changes
Nov 27, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 20/560 tests failed ⚠.
The first 10 failing tests are:
sc_tableversion_logicalsc_generated [setup failure]
sc_timepart_logicalsc_generated
simple_timepart_reptimeout_generated
simple_timepart
simple_ssl
random_osql_replay
yast_stat4scan_generated
yast
sc_blob_update_logicalsc_generated
sc_blob_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/bloomberg/comdb2/pull/4752/files