feat: update ami chart script #4408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
YazeedLoonat
requested changes
Oct 21, 2024
| @@ -17,6 +17,8 @@ import { Application } from '../dtos/applications/application.dto'; | |||
| import { AmiChartImportDTO } from '../dtos/script-runner/ami-chart-import.dto'; | |||
| import { AmiChartCreate } from '../dtos/ami-charts/ami-chart-create.dto'; | |||
| import { AmiChartService } from './ami-chart.service'; | |||
| import { AmiChartUpdate } from 'src/dtos/ami-charts/ami-chart-update.dto'; | |||
There was a problem hiding this comment.
these should be relative imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 🤷
Description
New script runner endpoint to update a AMI Charts values based on the AMI Chart ID.
How Can This Be Tested/Reviewed?
Sign in as an admin user to the partners portal.
Pick an AMI Chart to update. Copy the ID.
Using OpenAPI or ThunderClient, call the
/scriptRunner/amiChartUpdateImportby passing in the id and the correctly formatted values.Confirm in the partners portal that the AMI Chart values are appearing as expected.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: