Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add preview check #4126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ColinBuyck
Copy link
Collaborator

This PR addresses #668

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This logic update allows for partner users to see the application section of the listing detail page if they're in preview mode.

How Can This Be Tested/Reviewed?

Run locally, close a listing, make changes to that listing (ie. add a paper application), ensure those updates are reflected when you preview that closed listing.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ColinBuyck ColinBuyck added the 1 review needed Requires 1 more review before ready to merge label Jun 10, 2024
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit a6766f5
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/666785ee39e1c40008141344
😎 Deploy Preview https://deploy-preview-4126--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mcgarrye mcgarrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! though personally don't love this change but whatcha gonna do. LGTM

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 11, 2024
@ColinBuyck
Copy link
Collaborator Author

Yeahhh, I feel you @mcgarrye. I'm going to double check with Product and Design before merging and pulling this over.

@@ -626,7 +626,7 @@ export const ListingView = (props: ListingProps) => {
{!applicationsClosed && getWaitlist()}
{hasNonReferralMethods &&
!applicationsClosed &&
listing.status !== ListingsStatusEnum.closed ? (
(listing.status !== ListingsStatusEnum.closed || props.preview) ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this still have the issue of if they are trying to reopen a listing that the application due date is in the past? I guess they shouldn't be publishing a listing like that, but they might want to still preview it. And even in that case an easy fix for them would to update the application due date to something in the future.

Copy link
Collaborator Author

@ColinBuyck ColinBuyck Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will still have that behavior but my thought was that it wouldn't be an issue because it is representing what the listing would show when published. I know some admin use preview as a final "does everything look good" check and I think I'd prefer a closed application flagged to them then.

@ColinBuyck ColinBuyck added the on hold Temporarily paused work label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Temporarily paused work ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants