refactor: connection and functions #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirvolek
changed the title
michalrus
reviewed
Nov 14, 2024
| @@ -22,44 +17,9 @@ pub struct NodeConn { | |||
| } | |||
|
|
|||
| impl NodeConn { | |||
| /// Submits a transaction to the connected Cardano node. | |||
| pub async fn submit_transaction(&mut self, tx: String) -> Result<String, BlockfrostError> { | |||
There was a problem hiding this comment.
I don’t know if @ginnun didn't mean to keep the interface as it was, so we could still call NodeConn::submit_transaction, but move the implementations out?
So the pub fns in NodeConn would just be proxy methods?
There's definitely room for a discussion :)
There was a problem hiding this comment.
Sorry I am late to the party. I think we can aim to have one interface to call whatever we need, but split the interface whenever we want.
Meaning;
- Expose all the functionality via
NodeCon::whatever(renameNodeConntoNodeClient?) - Split the functnianality implementation into multiple hidden modules. Similar to Pallas itself, but the interface is one big interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.