Blitz recipe-install support for NextJS App Router projects #4287

Doc0x1 · 2024-01-22T18:08:07Z

What are the changes and their implications?

Bringing the Blitz recipe-install feature up to speed with the newer NextJS App Router projects.

TODO:

Change paths.ts so that it can check and return proper App Router paths/files. There's no _app file in App Router projects so as of the initial commit, it is set to return the root layout file of the project.
Add in error handling for cases where folders may not exist in a NextJS App Router filesystem

Closes: #4189

Feature Checklist

Changeset added (run pnpm changeset in the root directory)
Documentation added/updated (submit PR to blitzjs.com repo main branch)

Just a heads up, this is my first time contributing to a community project on GitHub, and so there's been a lot of new things I've been picking up in a pretty short amount of time. I've done my best to follow the contributing guidelines and if I've made any mistakes, feel free to let me know so I can avoid them in the future.

Anyway, this pull request is by no means ready for a merge, but I wanted to open it so I could get some feedback from those of you that might be more familiar with the recipe system than I currently am.

…with NextJS's App Router filesystem.

changeset-bot · 2024-01-22T18:08:10Z

🦋 Changeset detected

Latest commit: 0289d65

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Doc0x1 · 2024-01-22T18:11:02Z

I think the logical next step would be adding better error handling to prevent it from hanging during a recipe install. Having it create non-existent folders is one idea I've had.

Looking over it, the issue happens at the .addTransformFilesStep part of the recipe, at least for the tailwind recipe. Working on a way to implement better error handling in the transform.ts file so it doesn't hang.

siddhsuresh · 2024-01-24T05:28:28Z

I think the logical next step would be adding better error handling to prevent it from hanging during a recipe install. Having it create non-existent folders is one idea I've had.

Looking over it, the issue happens at the .addTransformFilesStep part of the recipe, at least for the tailwind recipe. Working on a way to implement better error handling in the transform.ts file so it doesn't hang.

yeah @Doc0x1 that's a good idea. Let me know when the PR is ready for a review!

…s#4290) * Added support for legacy projects that have the pages folder located inside a /src directory * Fixed line 687 for path.resolve(`${findPagesDirectory}/api/rpc`) not actually calling the function and added path.resolve's to findPagesDirectory * Update for lines 56 and 1340 to add support for app and pages directories located in /src

Doc0x1 · 2024-01-26T20:39:34Z

I think the logical next step would be adding better error handling to prevent it from hanging during a recipe install. Having it create non-existent folders is one idea I've had.

Looking over it, the issue happens at the .addTransformFilesStep part of the recipe, at least for the tailwind recipe. Working on a way to implement better error handling in the transform.ts file so it doesn't hang.

yeah @Doc0x1 that's a good idea. Let me know when the PR is ready for a review!

Will do. I just got some good web dev work so its gonna be maybe a couple weeks before im able to get back to actively working on this, so just a heads up. Glad i could help with getting that other PR done though

siddhsuresh · 2024-01-28T05:37:51Z

recipes/tailwind/templates/config/tailwind.config.js

+  content: [
+    "./{src/pages,src/components,src/app,src,pages,components,app}/**/*.{js,ts,jsx,tsx,mdx}",
+  ],


🍰 https://nextjs.org/docs/app/building-your-application/styling/tailwind-css#configuring-tailwind

Suggested change

content: [

"./{src/pages,src/components,src/app,src,pages,components,app}/**/*.{js,ts,jsx,tsx,mdx}",

],

content: [

'./app/**/*.{js,ts,jsx,tsx,mdx}',

'./pages/**/*.{js,ts,jsx,tsx,mdx}',

'./components/**/*.{js,ts,jsx,tsx,mdx}',

'./src/**/*.{js,ts,jsx,tsx,mdx}',

],

* perf: add check to make sure only non expired sessions are selected by default * remove console.logs * Create chatty-ants-bake.md * remove `expiresAt` from the publicData * remove internal from changelog --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat: export `BlitzServerMiddleware` from blitz-next * Create sixty-pants-hunt.md --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* add ajv to devDeps * Create four-dots-retire.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… Nextjs 13 or higher (blitz-js#4299) * fix: remove custom errors thrown by blitz * Create curvy-cougars-lick.md * use require and eval rather than the await which becomes a `yield import` possibly causing the issue * pnpm lock fix * Update .changeset/curvy-cougars-lick.md * add comment * use correct error type * Apply suggestions from code review

…#4300) * feat: remove restriction to use secure cookies in localhost * changeset * pnpm lock fix * Update .changeset/grumpy-deers-rest.md * Update .changeset/grumpy-deers-rest.md --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* Version Packages * pnpm lock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

* fix: process.kill("SIGABRT") not supported on windows * fix: use process.kill("SIGINT") across all operative systems * Update .changeset/clever-insects-shave.md --------- Co-authored-by: Siddharth Suresh <[email protected]>

* fix: production issue * Update .changeset/soft-tables-ring.md --------- Co-authored-by: Siddharth Suresh <[email protected]>

* Version Packages * chore: update pnpm lock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

…blitz-js#4318) * fix stray DYNAMIC_SERVER_USAGE thrown * cleanup * chore: changeset

* Use this.rootContext instead of webpack internals Ensures the root context is read from the public API that webpack exposes. This is the first step for Turbopack support as Turbopack includes `this.rootContext` as well * Turbopack support for Blitz * Update packages/blitz-rpc/src/server/loader/server/loader-server.ts Co-authored-by: Tobias Koppers <[email protected]> * fix: CI and update next.js version in test app * feat: add tests for turbo and expose new `turbo` boolean * upgrade to latest next version * use latest canary in internal packages and tests * chore: add changeset * chore: minor fix on how the test is run * fix stray DYNAMIC_SERVER_USAGE thrown * cleanup * chore: changeset * pnpm lock fix * fix turbo tests * fixes * oops * add turbo config only when needed * remove need for any change to `next.config.js` --------- Co-authored-by: Tobias Koppers <[email protected]> Co-authored-by: Siddharth Suresh <[email protected]>

* Version Packages * pnpm lock fix --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

* fix: add missing host in next-auth adapter * Create red-masks-drop.md * Update .changeset/red-masks-drop.md

* do not oveeride existing config * Create calm-deers-sin.md * Update packages/blitz-next/src/index-server.ts

* Version Packages * update pnpm lock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

justinbalaguer · 2024-04-26T07:26:39Z

up

* move it back to index-server * fix turbopack * Create big-cars-raise.md * cleanup * fix * fix lint

* Version Packages * pnpm lock fix --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

* upgrade to latest v4 * Create warm-scissors-juggle.md * Update .changeset/warm-scissors-juggle.md * also check for flightcontrol platform

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

mvarchdev · 2024-06-12T14:41:29Z

I do not know what is the state, but I tried blitz and I have just issues, this is one of them... ERR_INVALID_ARG_TYPE, The "path" argument must be of type string or an instance of Buffer or URL. Received undefined, probably does soemthing with this

JWBrownie · 2024-06-24T21:52:29Z

I am still having this issue as of for version 2.0.10 is it safe to use the recipe even if it errors out?

Thanks,

)

…with NextJS's App Router filesystem.

Doc0x1 · 2024-06-27T03:45:04Z

Might need to close this one, was working on updating it for the current upstream main branch of Blitz and not sure if I did so correctly.

siddhsuresh · 2024-09-29T21:13:25Z

Hey, I am closing this for now, feel free to reopen it and request a re-review when possible. Thanks!

Doc0x1 · 2024-10-11T16:32:54Z

Hey, I am closing this for now, feel free to reopen it and request a re-review when possible. Thanks!

Yeah no problem, I actually need to look through the code again and get a better understanding of how the generator functions before finishing it up in the future.

Doc0x1 added 2 commits January 21, 2024 11:07

Initial commit working towards making the Blitz installer compatible …

737630b

…with NextJS's App Router filesystem.

Changeset Update

019bf27

Doc0x1 requested a review from flybayer as a code owner January 22, 2024 18:08

blitzjs-bot added the status/in-review label Jan 22, 2024

siddhsuresh requested review from siddhsuresh and removed request for flybayer January 22, 2024 19:09

Doc0x1 and others added 2 commits January 25, 2024 14:18

(meta) added @Doc0x1 as contributor

0a8d4bf

tordans mentioned this pull request Jan 27, 2024

Update recipes #3919

Merged

22 tasks

siddhsuresh reviewed Jan 28, 2024

View reviewed changes

siddhsuresh and others added 16 commits February 6, 2024 16:13

feat: export BlitzServerMiddleware from blitz-next (blitz-js#4296)

28a7904

* feat: export `BlitzServerMiddleware` from blitz-next * Create sixty-pants-hunt.md --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

fix: ajv dependency was not installed with blitz new (blitz-js#4297)

71b9950

* add ajv to devDeps * Create four-dots-retire.md

Version Packages (blitz-js#4292)

e8f564e

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Version Packages (blitz-js#4301)

6f44c23

* Version Packages * pnpm lock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

(meta) added @lmisea as contributor

0f5297f

chore: remove --no-frozen-lockfile install step for release workflow

744242f

fix: production issue (blitz-js#4311)

5a587a6

* fix: production issue * Update .changeset/soft-tables-ring.md --------- Co-authored-by: Siddharth Suresh <[email protected]>

(meta) added @gengjiawen as contributor

a674897

chore: override version of mime blocking release CI

60a4d90

chore: upgrade release CI to latest versions

9b075db

Version Packages (blitz-js#4316)

bbe1a54

* Version Packages * chore: update pnpm lock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

fix: pages and app directory - Uncaught Error: DYNAMIC_SERVER_USAGE (…

178c152

…blitz-js#4318) * fix stray DYNAMIC_SERVER_USAGE thrown * cleanup * chore: changeset

timneutkens and others added 7 commits April 5, 2024 10:28

(meta) added @timneutkens as contributor

b7dab1d

internal: unblock the changeset release

19afc57

Version Packages (blitz-js#4320)

22e402a

* Version Packages * pnpm lock fix --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

fix: add missing host in next-auth adapter (blitz-js#4325)

7755546

* fix: add missing host in next-auth adapter * Create red-masks-drop.md * Update .changeset/red-masks-drop.md

bug: merge existing and blitz turbo config (blitz-js#4323)

5e61a16

* do not oveeride existing config * Create calm-deers-sin.md * Update packages/blitz-next/src/index-server.ts

Version Packages (blitz-js#4327)

6e8eeb1

* Version Packages * update pnpm lock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

siddhsuresh and others added 6 commits May 9, 2024 14:05

regression: export enhancePrisma from the brower (blitz-js#4326)

5a14306

* move it back to index-server * fix turbopack * Create big-cars-raise.md * cleanup * fix * fix lint

Version Packages (blitz-js#4333)

ad94bee

* Version Packages * pnpm lock fix --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <[email protected]>

Delete .node-version (blitz-js#4340)

0df3683

feat: upgrade to latest next-auth v4 version (blitz-js#4345)

318e974

* upgrade to latest v4 * Create warm-scissors-juggle.md * Update .changeset/warm-scissors-juggle.md * also check for flightcontrol platform

Version Packages (blitz-js#4346)

3193bde

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore: update pnpm lock to latest

721461a

RedYetiDev and others added 2 commits June 13, 2024 19:08

fix: use the correct SHA for pr-release.yml (blitz-js#4348)

2f3c552

(meta) added @RedYetiDev as contributor

f02469a

RedYetiDev and others added 6 commits June 26, 2024 19:29

fix: use correct bash syntax (blitz-js#4349)

e0cfa32

chore: remove check for comment time in PR release action (blitz-js#4351

2560175

)

Initial commit working towards making the Blitz installer compatible …

43bc6df

…with NextJS's App Router filesystem.

Upstream Rebase

34f4085

Updated tailwind.config.js

bfbadae

Merge branch 'main' of github.com:Doc0x1/blitz

c315c1e

pnpm-lock.yaml fix

0289d65

siddhsuresh closed this Sep 29, 2024

blitzjs-bot added the status/done label Sep 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blitz recipe-install support for NextJS App Router projects #4287

Blitz recipe-install support for NextJS App Router projects #4287

Doc0x1 commented Jan 22, 2024 •

edited

Loading

changeset-bot bot commented Jan 22, 2024 •

edited

Loading

Doc0x1 commented Jan 22, 2024 •

edited

Loading

siddhsuresh commented Jan 24, 2024

Doc0x1 commented Jan 26, 2024

siddhsuresh Jan 28, 2024

justinbalaguer commented Apr 26, 2024

mvarchdev commented Jun 12, 2024

JWBrownie commented Jun 24, 2024

Doc0x1 commented Jun 27, 2024

siddhsuresh commented Sep 29, 2024

Doc0x1 commented Oct 11, 2024

-  content: [
-    "./{src/pages,src/components,src/app,src,pages,components,app}/**/*.{js,ts,jsx,tsx,mdx}",
-  ],
+  content: [
+    './app/**/*.{js,ts,jsx,tsx,mdx}',
+    './pages/**/*.{js,ts,jsx,tsx,mdx}',
+    './components/**/*.{js,ts,jsx,tsx,mdx}',
+    './src/**/*.{js,ts,jsx,tsx,mdx}',
+  ],

Blitz recipe-install support for NextJS App Router projects #4287

Blitz recipe-install support for NextJS App Router projects #4287

Conversation

Doc0x1 commented Jan 22, 2024 • edited Loading

What are the changes and their implications?

Feature Checklist

changeset-bot bot commented Jan 22, 2024 • edited Loading

🦋 Changeset detected

Doc0x1 commented Jan 22, 2024 • edited Loading

siddhsuresh commented Jan 24, 2024

Doc0x1 commented Jan 26, 2024

siddhsuresh Jan 28, 2024

Choose a reason for hiding this comment

justinbalaguer commented Apr 26, 2024

mvarchdev commented Jun 12, 2024

JWBrownie commented Jun 24, 2024

Doc0x1 commented Jun 27, 2024

siddhsuresh commented Sep 29, 2024

Doc0x1 commented Oct 11, 2024

Doc0x1 commented Jan 22, 2024 •

edited

Loading

changeset-bot bot commented Jan 22, 2024 •

edited

Loading

Doc0x1 commented Jan 22, 2024 •

edited

Loading