MB-69881: Updated interfaces for more performant vector search #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox,
Copilot and
maneuvertomars
There was a problem hiding this comment.
Pull request overview
This PR re-architects the vector search API by introducing a new abstraction layer for eligible document filtering. The changes modify interface definitions to enable visitor-style iteration in the storage layer and remove redundant parameters.
- Introduces
EligibleDocumentListabstraction to replace direct slice usage inSearchWithFilter, enabling more flexible document filtering implementations - Removes the redundant
requiresFilteringboolean parameter fromInterpretVectorIndex, simplifying the interface - Adds comprehensive documentation comments for the
VectorIndexinterface methods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abhinavdangeti
previously approved these changes
Jan 8, 2026
abhinavdangeti
changed the title
abhinavdangeti
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abhinavdangeti
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchWithFilterAPI that accepts anEligibleDocumentListinstead of a slice of docIDs, enabling a visitor-style iteration in the storage layer and abstracting away eligible-document representation and implementation details.requiresFilteringflag inInterpretVectorIndexinterface.