Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
After you've implemented #37 I opened an enhancement request for the node-oracledb driver (see oracle/node-oracledb#1629). This was accepted and implemented in version 6.4.0 of the node-oracledb driver. Oracle also opened a PR for the type definition (see DefinitelyTyped/DefinitelyTyped#69327). This PR has been accepted and is now included in version 6.4.0 of @types/oracldb on npm.
So, OracleDB is now a first-class citizen as PostgreSQL and MySQL (when using sql-template-tag >=5.2.0, node-oracledb >=6.4.0 and @types/oracledb >=6.4.0).
Change
This PR updates the README regarding
query.statement
andquery.values
which are now automatically considered by the latest node-oracledb driver.