Remove need for string allocation in SA1316TupleElementNamesShouldUse…

…CorrectCasing unless a diagnostic will be issued
bjornhellander · Mar 22, 2024 · c9debeb · c9debeb
1 parent 6327501
commit c9debeb
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...Analyzers/StyleCop.Analyzers/NamingRules/SA1316TupleElementNamesShouldUseCorrectCasing.cs b/...Analyzers/StyleCop.Analyzers/NamingRules/SA1316TupleElementNamesShouldUseCorrectCasing.cs
@@ -115,18 +115,18 @@ private static void CheckName(SyntaxNodeAnalysisContext context, StyleCopSetting
             var firstCharacterIsLower = char.IsLower(tupleElementName[0]);
 
             bool reportDiagnostic;
-            string fixedName;
+            char fixedFirstChar;
 
             switch (settings.NamingRules.TupleElementNameCasing)
             {
             case TupleElementNameCase.PascalCase:
                 reportDiagnostic = firstCharacterIsLower;
-                fixedName = char.ToUpper(tupleElementName[0]) + tupleElementName.Substring(1);
+                fixedFirstChar = char.ToUpper(tupleElementName[0]);
                 break;
 
             default:
                 reportDiagnostic = !firstCharacterIsLower;
-                fixedName = char.ToLower(tupleElementName[0]) + tupleElementName.Substring(1);
+                fixedFirstChar = char.ToLower(tupleElementName[0]);
                 break;
             }
 
@@ -136,6 +136,7 @@ private static void CheckName(SyntaxNodeAnalysisContext context, StyleCopSetting
 
                 if (prepareCodeFix)
                 {
+                    var fixedName = fixedFirstChar + tupleElementName.Substring(1);
                     diagnosticProperties.Add(ExpectedTupleElementNameKey, fixedName);
                 }