Update app startup logic to be compatible with URL-based navigation and deep links #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
AppStartupWidgetsetup wasn't playing nice with deep links and URL navigation when used withMaterialApp.router/ GoRouter.This PR fixes this with two changes:
/startuproute (the app startup logic is about application state, but shouldn't have anything to do with routing)MaterialApp.builderto return theAppStartupWidget. This way,AppStartupWidgetcan control any asynchronous app initialization without interfering with the routing logic, and returns the intended child widget only when the initialization is done.To better support passing the child when loading is complete, a new
AppStartupDataWidgetclass has been added.