[PM-7918] Design Feedback and other cleanup #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprusik
commented
May 3, 2024
Comment on lines
+55
to
+56
| // https://github.com/facebook/docusaurus/issues/9665 | ||
| // https://github.com/facebook/docusaurus/issues/9688 |
There was a problem hiding this comment.
Discussion on both facebook/docusaurus#9665 and facebook/docusaurus#9688 offers some workarounds, but they didn't work well here without a lot of extra refactors which I opted not to get into here.
jprusik
commented
May 3, 2024
Comment on lines
-62
to
-72
| .theme-doc-markdown > header:first-of-type details > summary { | ||
| list-style: none; | ||
| } | ||
| .theme-doc-markdown > header:first-of-type details > summary::after { | ||
| font-size: 24px; | ||
| content: " ▸"; | ||
| } | ||
| .theme-doc-markdown > header:first-of-type details[open] > summary::after { | ||
| font-size: 24px; | ||
| content: " ▾"; | ||
| } |
There was a problem hiding this comment.
Leftover styling from 26a4ff2
jprusik
commented
May 3, 2024
There was a problem hiding this comment.
No longer needed thanks to facebook/docusaurus#10061 in v3.3.0
danielleflinn
approved these changes
May 3, 2024
cagonzalezcs
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-7918
📔 Objective
Implement feedback from @danielleflinn , as well as some additional cleanup I spotted along the way
📸 Screenshots
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes