Skip to content

[PM-30327] Fix SingleOrg policy not revoking non-compliant users#7001

Open
r-tome wants to merge 1 commit intomainfrom
ac/pm-30327/non-compliant-users-are-not-revoked-when-single-organization-policy-is-enabled
Open

[PM-30327] Fix SingleOrg policy not revoking non-compliant users#7001
r-tome wants to merge 1 commit intomainfrom
ac/pm-30327/non-compliant-users-are-not-revoked-when-single-organization-policy-is-enabled

Conversation

@r-tome
Copy link
Contributor

@r-tome r-tome commented Feb 13, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30327

📔 Objective

Fix a bug in the Entity Framework (Bitwarden Lite) implementation where enabling the Single Organization policy failed to revoke non-compliant users.
The GetManyAsync query in the EF OrganizationUserRepository was incorrectly filtering by OrganizationUser.Id instead of OrganizationUser.UserId, causing the revocation lookup to miss matching users. The Dapper (cloud) implementation was not affected.
An integration test is added to verify the end-to-end behavior.

@r-tome r-tome marked this pull request as ready for review February 13, 2026 11:44
@r-tome r-tome requested a review from a team as a code owner February 13, 2026 11:44
@r-tome r-tome requested a review from jrmccannon February 13, 2026 11:44
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.32%. Comparing base (c15c418) to head (a080802).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7001      +/-   ##
==========================================
+ Coverage   56.28%   60.32%   +4.03%     
==========================================
  Files        1986     1986              
  Lines       87660    87667       +7     
  Branches     7814     7816       +2     
==========================================
+ Hits        49339    52881    +3542     
+ Misses      36490    32867    -3623     
- Partials     1831     1919      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse51e2e59-5169-4e8a-bac7-55fc60bb880c

Great job! No new security vulnerabilities introduced in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants