Skip to content

[PM-31776] Fix email-verified Send OTP email design discrepancies#6990

Open
mcamirault wants to merge 2 commits intomainfrom
tools/pm-31776/email-verified-send-otp-email-tweaks
Open

[PM-31776] Fix email-verified Send OTP email design discrepancies#6990
mcamirault wants to merge 2 commits intomainfrom
tools/pm-31776/email-verified-send-otp-email-tweaks

Conversation

@mcamirault
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31776

📔 Objective

This PR fixes a couple of discrepancies with the design of the OTP code email that is sent when accessing email-verified Sends. Since some of the requested changes were to the shared <mj-bw-learn-more-footer> component I had to regenerate some other email templates and also ran npm run prettier afterwards for formatting fixes

📸 Screenshots

Before

Screenshot 2026-02-11 at 15 27 43

After

Screenshot 2026-02-11 at 15 28 12

@mcamirault mcamirault requested review from a team as code owners February 11, 2026 20:46
@mcamirault mcamirault added the ai-review Request a Claude code review label Feb 11, 2026
JaredScar
JaredScar previously approved these changes Feb 11, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

Logo
Checkmarx One – Scan Summary & Details5111e953-507e-4298-81f1-e6fc01c68e52

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.28%. Comparing base (946a032) to head (5aa14c8).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6990      +/-   ##
==========================================
+ Coverage   56.26%   56.28%   +0.01%     
==========================================
  Files        1983     1986       +3     
  Lines       87651    87660       +9     
  Branches     7815     7814       -1     
==========================================
+ Hits        49318    49339      +21     
+ Misses      36503    36490      -13     
- Partials     1830     1831       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude
Copy link
Contributor

claude bot commented Feb 12, 2026

Claude finished @mcamirault's task in 3m 31s —— View job


Code Review Summary

PR: PM-31776 Fix email-verified Send OTP email design discrepancies

Overall Assessment: Approved -- Clean PR with targeted design fixes and formatting cleanup.

Changes Reviewed

Intentional design changes:

  • send-email-otp.mjml: Token display updated from <b> tag to font-weight: 500, copy text refined, line-height: 24px added to info section
  • mj-bw-learn-more-footer.js: Removed custom padding (now uses MJML default 20px 0), changed font-weight: bold to font-weight: 500, added margin-top: 0px

Formatting/cleanup:

  • Prettier formatting applied across all MJML source files and JS components
  • Handlebars variable spacing normalized ({{var}} to {{ var }})
  • README markdown formatting improvements

Generated output:

  • All 9 affected .html.hbs files correctly regenerated to reflect both the design and formatting changes
  • The 2 remaining MJML templates using mj-bw-learn-more-footer (invite.mjml, two-factor.mjml) appear to be development/preview templates without corresponding production HBS files, so no regeneration is needed

Suggestion (not in diff, mentioning here)

The plain text email template src/Core/MailTemplates/Handlebars/Auth/SendAccessEmailOtpEmail.text.hbs (line 8) still contains the old copy:

"Bitwarden Send transmits sensitive, temporary information to others easily and securely."

The HTML version was updated to:

"Bitwarden Send securely shares sensitive information."

Consider updating the text template for consistency between the two versions of this email.

@sonarqubecloud
Copy link

Copy link
Contributor

@vleague2 vleague2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIF files look good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants