Skip to content

[PM-29089] Remove FF: pm-26793-fetch-premium-price-from-pricing-service - Logic#6989

Open
amorask-bitwarden wants to merge 4 commits intomainfrom
billing/PM-29098/remove-ff-pm-26793_server-logic
Open

[PM-29089] Remove FF: pm-26793-fetch-premium-price-from-pricing-service - Logic#6989
amorask-bitwarden wants to merge 4 commits intomainfrom
billing/PM-29098/remove-ff-pm-26793_server-logic

Conversation

@amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented Feb 11, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29089

📔 Objective

Removes the PM26793_FetchPremiumPriceFromPricingService feature flag from PricingClient.ListPremiumPlans(), making the Pricing Service the permanent source for premium plan data. This includes:

  • Removing the feature flag check and hardcoded CurrentPremiumPlan fallback from ListPremiumPlans()
  • Cleaning up dead using statements (Bit.Core.Billing.Constants, Purchasable alias)
  • Adding unit test coverage for ListPremiumPlans and GetAvailablePremiumPlan

@amorask-bitwarden amorask-bitwarden changed the title [PM-29089] Remove FF: pm-26793-fetch-premium-price-from-pricing-service - server logic [PM-29089] Remove FF: pm-26793-fetch-premium-price-from-pricing-service - Logic Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.30%. Comparing base (c15c418) to head (3a6c6cb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6989      +/-   ##
==========================================
+ Coverage   56.28%   56.30%   +0.02%     
==========================================
  Files        1986     1986              
  Lines       87660    87647      -13     
  Branches     7814     7813       -1     
==========================================
+ Hits        49339    49354      +15     
+ Misses      36490    36461      -29     
- Partials     1831     1832       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsab14eb96-0d36-4c3d-83f0-43375632ef5b

Great job! No new security vulnerabilities introduced in this pull request

@amorask-bitwarden amorask-bitwarden marked this pull request as ready for review February 12, 2026 15:41
@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner February 12, 2026 15:42
@sonarqubecloud
Copy link

Copy link
Contributor

@cyprain-okeke cyprain-okeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants