Skip to content

[PM-29055] Remove FF: pm-25379-use-new-organization-metadata-structure#6966

Open
amorask-bitwarden wants to merge 4 commits intomainfrom
billing/PM-29055/remove-pm-25379-feature-flag
Open

[PM-29055] Remove FF: pm-25379-use-new-organization-metadata-structure#6966
amorask-bitwarden wants to merge 4 commits intomainfrom
billing/PM-29055/remove-pm-25379-feature-flag

Conversation

@amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented Feb 9, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29055

📔 Objective

Remove the fully-released pm-25379-use-new-organization-metadata-structure feature flag (Step 1 and 2 of the feature flag lifecycle).

This flag gated the new OrganizationMetadataService implementation backed by GetOrganizationMetadataQuery, exposed through VNext controllers. With the flag removed:

  • The VNext metadata endpoints (/billing/vnext/metadata and /billing/vnext/self-host/metadata) are now ungated and always available
  • The old /billing/metadata endpoint on OrganizationBillingController has been removed
  • The GetMetadata method has been removed from IOrganizationBillingService and its implementation, along with the IsOnSecretsManagerStandalone private helper
  • Associated tests have been cleaned up

Note: This PR must be merged and deployed before the corresponding clients PR, as the clients will exclusively call the VNext endpoints after their cleanup.

amorask-bitwarden and others added 2 commits February 9, 2026 13:34
…ture feature flag

Remove the fully-released feature flag and clean up the old code path:
- Remove flag constant from FeatureFlagKeys
- Remove [RequireFeature] gate from VNext billing controllers
- Remove old GetMetadataAsync endpoint from OrganizationBillingController
- Remove GetMetadata from IOrganizationBillingService and implementation
- Remove IsOnSecretsManagerStandalone private helper
- Remove associated tests
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Logo
Checkmarx One – Scan Summary & Detailsba5c067b-841c-4e95-a74f-b869eec7daca

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1178
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1062

@amorask-bitwarden amorask-bitwarden marked this pull request as ready for review February 9, 2026 21:00
@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner February 9, 2026 21:00
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.26%. Comparing base (37770b2) to head (c77fe3d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6966   +/-   ##
=======================================
  Coverage   56.25%   56.26%           
=======================================
  Files        1983     1983           
  Lines       87682    87624   -58     
  Branches     7833     7820   -13     
=======================================
- Hits        49326    49300   -26     
+ Misses      36525    36502   -23     
+ Partials     1831     1822    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants