Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13470] Allow creating clients for Multi-organization enterprise #4977

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonashendrickx
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13470

๐Ÿ“” Objective

  • We might be able to remove certain checks as we're not adding any plans.
  • We need to allow multi-organization enterprise

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner November 5, 2024 10:13
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@cb7eecc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...cial.Core/AdminConsole/Services/ProviderService.cs 57.14% 4 Missing and 2 partials โš ๏ธ
.../Commercial.Core/Billing/ProviderBillingService.cs 0.00% 1 Missing and 1 partial โš ๏ธ
...g/Models/Responses/ProviderSubscriptionResponse.cs 50.00% 2 Missing โš ๏ธ
src/Core/Billing/Extensions/BillingExtensions.cs 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4977   +/-   ##
=======================================
  Coverage        ?   42.54%           
=======================================
  Files           ?     1389           
  Lines           ?    64754           
  Branches        ?     5945           
=======================================
  Hits            ?    27549           
  Misses          ?    35982           
  Partials        ?     1223           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

cyprain-okeke
cyprain-okeke previously approved these changes Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants