[PM-13839][PM-13840] Admin Console Collections #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- They're now needed in the admin console when add/editing a cipher. - Prior to this there was no way to edit collection when editing a cipher. Assigning collections was a separate workflow
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4922 +/- ##
==========================================
+ Coverage 41.77% 42.57% +0.79%
==========================================
Files 1364 1387 +23
Lines 64050 64649 +599
Branches 5878 5932 +54
==========================================
+ Hits 26760 27524 +764
+ Misses 36084 35903 -181
- Partials 1206 1222 +16 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
shane-melton
previously approved these changes
Oct 25, 2024
shane-melton
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13839
PM-13840
Client Side PR
📔 Objective
Add collectionIds to the response of
{id}/admincollectionsIdsare the only difference in the new CipherMiniDetailsResponseModelstring[]rather thannull/undefined. This change would be more accurate with those types.📸 Screenshots
See Client Side PR
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes