[PM-13356] Fix iOS build by pinning dotnet and MAUI version #3410
+36
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variable. Also pinning .NET version to use to 8.0.7 so it's the same one as the latest public release.
…st public release
…s on dotnet publish, also commented other workflows.
|
Build with the latest changes: https://github.com/bitwarden/mobile/actions/runs/11262307839 |
fedemkr
previously approved these changes
Oct 9, 2024
Eeebru
reviewed
Oct 10, 2024
Eeebru
approved these changes
Oct 10, 2024
aj-rosado
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
iOS build was failing due to installing the latest MAUI version which depends on iOS 18, while using a dotnet version that doesn't support iOS 18. Pinned both dotnet sdk runtime and maui workload versions to the last that supports iOS 17.5.
Tried pinning them to the versions that we were using for the last release but (1) they weren't installing due to a bug in the dotnet version we were using and (2) it's possible that the MAUI version we had isn't available anymore.
Code changes
global.json: Pins the dotnet sdk runtime version. In
build.yml, the repo checkout step had to be moved up for this file to be usedbuild.yml:
* Pins dotnet sdk runtime version and MAUI workload version to 8.0.402, the last version that supports iOS 17.5
* Updates xcode version to 15.4, as required by MAUI 8.0.402
Before you submit
dotnet format --verify-no-changes) (required)