Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare strings for Android Crowdin sync #3327

Closed
wants to merge 1 commit into from

Conversation

SaintPatrck
Copy link

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

String resources, Continue and Default use key values that are protected keywords in Android XML resource files. In order to prepare the MAUI project for syncing with the native Android project these terms must have their keys replaced. To prevent losing translations for the existing keys we are adding matching resources that do not use protected keywords. Once translations have been migrated in Crowdin the legacy entries will be removed.

Code changes

  • AppResources.resx Add terms ContinueText and DefaultText.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@SaintPatrck
Copy link
Author

@vvolkgang I think we should go ahead and replace references to the old Continue and Default resources with the ones being added. The alternative is updating references when we remove the old ones. You have a preference?

@SaintPatrck SaintPatrck marked this pull request as ready for review June 20, 2024 20:15
@vvolkgang
Copy link
Member

@SaintPatrck I don't have a preference, if you're able to replace resources now without removing existing translations then let's go with that!

@SaintPatrck
Copy link
Author

No longer needed

@SaintPatrck SaintPatrck deleted the crowdin/replace-android-protected-keywords branch June 26, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants