Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-101] Remove dept-devops from CODEOWNERS #3289

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

michalchecinski
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

https://bitwarden.atlassian.net/browse/BRE-101

Remove dept-devops from CODEOWNERS and add dept-bre for .github/workflows/release.yml.

Code changes

  • .github/CODEOWNERS: Remove dept-devops and add dept-bre for .github/workflows/release.yml.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@michalchecinski michalchecinski added the hold do not merge yet label Jun 10, 2024
@michalchecinski
Copy link
Contributor Author

@michalchecinski michalchecinski requested a review from a team as a code owner October 14, 2024 11:25
@michalchecinski michalchecinski removed the hold do not merge yet label Oct 14, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
Comment on lines -13 to -18
# DevOps for Version Bumping
src/App/Platforms/Android/AndroidManifest.xml
src/iOS.Autofill/Info.plist
src/iOS.Extension/Info.plist
src/iOS.ShareExtension/Info.plist
src/App/Platforms/iOS/Info.plist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these back in. The comment can be updated to read # Shared ownership for version bump automation

.github/CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Vince Grassia <[email protected]>
@michalchecinski michalchecinski merged commit c957e46 into main Oct 17, 2024
8 of 12 checks passed
@michalchecinski michalchecinski deleted the BRE-101-Remove-dept-devops-from-CODEOWNERS branch October 17, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants