-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BRE-101] Remove dept-devops from CODEOWNERS #3289
Merged
michalchecinski
merged 6 commits into
main
from
BRE-101-Remove-dept-devops-from-CODEOWNERS
Oct 17, 2024
Merged
[BRE-101] Remove dept-devops from CODEOWNERS #3289
michalchecinski
merged 6 commits into
main
from
BRE-101-Remove-dept-devops-from-CODEOWNERS
Oct 17, 2024
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for the https://bitwarden.atlassian.net/servicedesk/customer/portal/5/TSD-648 to be done. |
vgrassia
requested changes
Oct 16, 2024
Comment on lines
-13
to
-18
# DevOps for Version Bumping | ||
src/App/Platforms/Android/AndroidManifest.xml | ||
src/iOS.Autofill/Info.plist | ||
src/iOS.Extension/Info.plist | ||
src/iOS.ShareExtension/Info.plist | ||
src/App/Platforms/iOS/Info.plist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add these back in. The comment can be updated to read # Shared ownership for version bump automation
Co-authored-by: Vince Grassia <[email protected]>
vgrassia
requested changes
Oct 17, 2024
Co-authored-by: Vince Grassia <[email protected]>
vgrassia
approved these changes
Oct 17, 2024
fedemkr
approved these changes
Oct 17, 2024
michalchecinski
deleted the
BRE-101-Remove-dept-devops-from-CODEOWNERS
branch
October 17, 2024 16:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
https://bitwarden.atlassian.net/browse/BRE-101
Remove
dept-devops
from CODEOWNERS and adddept-bre
for.github/workflows/release.yml
.Code changes
dept-devops
and adddept-bre
for.github/workflows/release.yml
.Screenshots
Before you submit
dotnet format --verify-no-changes
) (required)