Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14458: Update notifications permissions request #4229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Nov 4, 2024

🎟️ Tracking

PM-14458

πŸ“” Objective

This PR updates the way we request the notifications permission. Instead of prompting in the vault screen with no context, we not prompt in the Pending Requests Screen.

πŸ“Έ Screenshots

Screen_recording_20241104_163444.mp4

@david-livefront david-livefront force-pushed the PM-14458-notifications-permission branch from 4449834 to 837afbe Compare November 4, 2024 22:39
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 93.24324% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.06%. Comparing base (8f9585e) to head (837afbe).

Files with missing lines Patch % Lines
...tsecurity/pendingrequests/PendingRequestsScreen.kt 92.64% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4229   +/-   ##
=======================================
  Coverage   89.05%   89.06%           
=======================================
  Files         445      445           
  Lines       38700    38747   +47     
  Branches     5412     5414    +2     
=======================================
+ Hits        34464    34509   +45     
- Misses       2359     2361    +2     
  Partials     1877     1877           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant