Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump authenticatorbridge sdk version to 1.0.0 #4221

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

ahaisting-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

Version bump and put in SDK version 1.0.0. I'll link to authenticator app update shortly.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (2f6578f) to head (0a484f0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4221   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files         445      445           
  Lines       38652    38652           
  Branches     5402     5402           
=======================================
  Hits        34421    34421           
  Misses       2357     2357           
  Partials     1874     1874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dseverns-livefront dseverns-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahaisting-livefront
Copy link
Collaborator Author

Thanks, @david-livefront and @dseverns-livefront <3

@ahaisting-livefront ahaisting-livefront added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 8f9585e Nov 4, 2024
9 checks passed
@ahaisting-livefront ahaisting-livefront deleted the authenticatorbridge-1.0.0 branch November 4, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants