[PM-13360] Respect manage permission to assign collections #4190
+1,337
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PM-12922/delete-collection-permission #4190 +/- ##
========================================================================
Coverage ? 89.03%
========================================================================
Files ? 445
Lines ? 38714
Branches ? 5442
========================================================================
Hits ? 34468
Misses ? 2344
Partials ? 1902 ☔ View full report in Codecov by Sentry. |
…cResponseJson This commit adds the `canManage` property to the `CollectionEntity` and `SyncResponseJson` classes to support the management of collections. It also includes necessary test updates and updates to the database schema to reflect these changes.
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
2 times, most recently
from
b935392
to
17d36f0
Compare
Disables the delete button for items in collections where the user does not have "manage" permission. This change ensures that users cannot delete items from collections they are not authorized to manage. It updates the UI to reflect the user's permissions and prevents accidental or unauthorized deletions.
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
from
17d36f0
to
9850607
Compare
This commit prevents users from assigning items to collections if the item is already in a read-only collection where the user does not have "manage" permission. This change ensures that users with limited permissions cannot modify items in a way that violates the collection's access controls.
SaintPatrck
force-pushed
the
PM-13360/collection-association-permission
branch
from
9d8e0f0
to
76954d4
Compare
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
4 times, most recently
from
4d2f1c2
to
70a7e99
Compare
| .takeUnless { | ||
| state.isAddItemMode || | ||
| (!state.isCipherInCollection || | ||
| !state.canAssociateToCollections) |
There was a problem hiding this comment.
You don't need these parenthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13360
📔 Objective
This commit prevents users from assigning items to collections if the item is already in a read-only collection where the user does not have "manage" permission.
This change ensures that users with limited permissions cannot modify items in a way that violates the collection's access controls.
📸 Screenshots
Coming soon!
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes