-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-12922] Disable delete if user can't manage collection #4179
Open
SaintPatrck
wants to merge
2
commits into
main
Choose a base branch
from
PM-12922/delete-collection-permission
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+502
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
from
October 29, 2024 14:22
b384ccd
to
60b1167
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PM-13900/update-bw-sdk #4179 +/- ##
==========================================================
- Coverage 89.09% 89.06% -0.04%
==========================================================
Files 445 445
Lines 38650 38683 +33
Branches 5406 5424 +18
==========================================================
+ Hits 34435 34452 +17
- Misses 2343 2344 +1
- Partials 1872 1887 +15 ☔ View full report in Codecov by Sentry. |
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
3 times, most recently
from
October 29, 2024 19:07
711a7fa
to
ccdfa02
Compare
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
from
October 29, 2024 19:11
ccdfa02
to
0a965c8
Compare
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
October 29, 2024 19:16
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt
Outdated
Show resolved
Hide resolved
SaintPatrck
force-pushed
the
PM-13900/update-bw-sdk
branch
from
October 29, 2024 22:15
373f327
to
c97ea2d
Compare
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
3 times, most recently
from
October 29, 2024 22:25
17d36f0
to
9850607
Compare
david-livefront
previously approved these changes
Oct 30, 2024
SaintPatrck
dismissed
david-livefront’s stale review
October 30, 2024 16:20
The base branch was changed.
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
from
October 30, 2024 16:29
9850607
to
cfc666d
Compare
david-livefront
previously approved these changes
Oct 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2024
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
from
October 30, 2024 20:03
cfc666d
to
da59d05
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 30, 2024
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
from
October 31, 2024 14:24
da59d05
to
4d2f1c2
Compare
Disables the delete button for items in collections where the user does not have "manage" permission. This change ensures that users cannot delete items from collections they are not authorized to manage. It updates the UI to reflect the user's permissions and prevents accidental or unauthorized deletions.
SaintPatrck
force-pushed
the
PM-12922/delete-collection-permission
branch
from
October 31, 2024 14:29
4d2f1c2
to
70a7e99
Compare
david-livefront
approved these changes
Oct 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12992
📔 Objective
Disables the delete button for items in collections where the user does not have "manage" permission.
This change ensures that users cannot delete items from collections they are not authorized to manage. It updates the UI to reflect the user's permissions and prevents accidental or unauthorized deletions.
Depends on #4169
📸 Screenshots
Coming soon!
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes