Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-13789] add credential manager provider for passwords #4110

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

[PM-13789] add credential manager provider for passwords #4110

wants to merge 30 commits into from

Commits on Oct 19, 2024

  1. add BitwardenPasswordProviderService as CredentialProviderService for… 

    … android.credentials.TYPE_PASSWORD_CREDENTIAL
    @Nailik
    Nailik committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    fc882d2 View commit details
    Browse the repository at this point in the history

  2. add intents for PasswordProviderProcessor

    @Nailik
    Nailik committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1f301f2 View commit details
    Browse the repository at this point in the history

  3. initial test to provide Password Credential Entry

    @Nailik
    Nailik committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ab9161c View commit details
    Browse the repository at this point in the history

  4. PasswordIntentUtils according to Fido2IntentUtils

    @Nailik
    Nailik committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ab361c9 View commit details
    Browse the repository at this point in the history

  5. add SpecialCircumstance to handle PasswordCredential intents

    @Nailik
    Nailik committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c3473b9 View commit details
    Browse the repository at this point in the history

  6. add RootNavState for PasswordCredential

    @Nailik
    Nailik committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    cab85a9 View commit details
    Browse the repository at this point in the history

  7. finish Save PasswordCredential via Credential Manager Api

    @Nailik
    Nailik committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c74bc86 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. GetPasswordCredentialRequest handling

    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    5a6e528 View commit details
    Browse the repository at this point in the history

  2. empty username/password instead of error on credential selection

    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    b30ebd9 View commit details
    Browse the repository at this point in the history

  3. renamed BitwardenFido2ProviderService.kt to BitwardenCredentialProvid… 

    …erService.kt
    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    94cd7af View commit details
    Browse the repository at this point in the history

  4. combined fido2 and password credential provider into BitwardenCredent… 

    …ialProviderService in order to not show 2 locked entries in the credential api.
    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    1ec7bdd View commit details
    Browse the repository at this point in the history

  5. Revert "combined fido2 and password credential provider into Bitwarde… 

    …nCredentialProviderService in order to not show 2 locked entries in the credential api."

This reverts commit 1ec7bdd.
    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    c0190c0 View commit details
    Browse the repository at this point in the history

  6. remove unused

    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    9d422e2 View commit details
    Browse the repository at this point in the history

  7. Revert "Revert "combined fido2 and password credential provider into … 

    …BitwardenCredentialProviderService in order to not show 2 locked entries in the credential api.""

This reverts commit c0190c0.
    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    9398697 View commit details
    Browse the repository at this point in the history

  8. combine provider service

    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    07949fd View commit details
    Browse the repository at this point in the history

  9. password assertion

    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    040e4f3 View commit details
    Browse the repository at this point in the history

  10. rework Fido2CompletionManager.kt to CredentialCompletionManager to su… 

    …pport request for passkeys and passwords at the same time
    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    52f02d1 View commit details
    Browse the repository at this point in the history

  11. WIP improve saving password credentials

    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    0a838fa View commit details
    Browse the repository at this point in the history

  12. WIP overwriting already present username/password combinations (dialogs)

    @Nailik
    Nailik committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    12b37c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. dialogs

    @Nailik
    Nailik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bf7a725 View commit details
    Browse the repository at this point in the history

  2. overwrite confirmation dialog state text

    @Nailik
    Nailik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9d5e340 View commit details
    Browse the repository at this point in the history

  3. removed unused import

    @Nailik
    Nailik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d13a582 View commit details
    Browse the repository at this point in the history

  4. reuse open bitwarden action

    @Nailik
    Nailik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6eb6907 View commit details
    Browse the repository at this point in the history

  5. handle password error in unlock screen

    @Nailik
    Nailik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e9aae37 View commit details
    Browse the repository at this point in the history

  6. clean up

    @Nailik
    Nailik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    38465ed View commit details
    Browse the repository at this point in the history

  7. fix manifest

    @Nailik
    Nailik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b344e71 View commit details
    Browse the repository at this point in the history

  8. comments

    @Nailik
    Nailik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4c7f7ae View commit details
    Browse the repository at this point in the history

  9. reformat code

    @Nailik
    Nailik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    518d60a View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Merge branch 'main' into feature/add-password-credential-manager-prov… 

    …ider
    @Nailik
    Nailik authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1dd1c4e View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Merge branch 'main' into feature/add-password-credential-manager-prov… 

    …ider

# Conflicts:
#	app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt
    @Nailik
    Nailik committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3525469 View commit details
    Browse the repository at this point in the history