New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Libs] Fix PrivateKey instantiation with trimmed hex #3832

Open

kajoseph wants to merge 4 commits into bitpay:master from kajoseph:fixPrivateKeyHex

Collaborator

kajoseph commented Dec 17, 2024

This PR:

Fixes PrivateKey instantiation with hex strings that are missing leading zeros. See newly added test for an example.
Adds tests
Cleans up new Buffer (deprecated) and new BN(Buffer.from (misleading)

kajoseph added 4 commits

December 17, 2024 10:13


          fix privatekey trimmed hex input

b0cd371


          new Buffer => Buffer.from

d7528d4


          clean up incorrect BN instantiation with hex

330882d


          fix doge tests

d158019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet