-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substitute lodash calls in bitcore-lib #3350
Open
picnicbear
wants to merge
11
commits into
bitpay:master
Choose a base branch
from
picnicbear:bitcore-lib/removeLodash
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
65d42f3
substitute lodash calls in bitcore-lib
6f0a0ab
update addNetwork (lodash removal changes)
ed75389
fix invalid syntax from regex replacement
9063482
update valid Base58.validCharacters to handle a string
36942f2
add missing require for lodash, todo comments
3ee7b35
remove lodash from tests, convert forEaches to for loops, replace use…
ac1d7b9
convert undefined checks to check equality instead of variable type, …
ee5e904
Merge branch 'master' of https://github.com/bitpay/bitcore into bitco…
4c62827
add utils for sort, isObject, and shuffle to util/js, update more und…
0262431
replace dependencies on bitcore-lib's lodash outside of bitcore-lib
0bdc2d2
linting, replace lodash ref in bitcore p2p tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,6 @@ | |
|
||
var BN = require('bn.js'); | ||
var $ = require('../util/preconditions'); | ||
var _ = require('lodash'); | ||
|
||
var reversebuf = function(buf) { | ||
var buf2 = Buffer.alloc(buf.length); | ||
|
@@ -17,17 +16,17 @@ BN.One = new BN(1); | |
BN.Minus1 = new BN(-1); | ||
|
||
BN.fromNumber = function(n) { | ||
$.checkArgument(_.isNumber(n)); | ||
$.checkArgument(typeof n === 'number'); | ||
return new BN(n); | ||
}; | ||
|
||
BN.fromString = function(str, base) { | ||
$.checkArgument(_.isString(str)); | ||
$.checkArgument(typeof str === 'string'); | ||
return new BN(str, base); | ||
}; | ||
|
||
BN.fromBuffer = function(buf, opts) { | ||
if (typeof opts !== 'undefined' && opts.endian === 'little') { | ||
if (opts !== undefined && opts.endian === 'little') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably make
and
Same on line 89 Maybe consider changing all checks for undefined to checks for null as well (i.e. |
||
buf = reversebuf(buf); | ||
} | ||
var hex = buf.toString('hex'); | ||
|
@@ -87,7 +86,7 @@ BN.prototype.toBuffer = function(opts) { | |
buf = Buffer.from(hex, 'hex'); | ||
} | ||
|
||
if (typeof opts !== 'undefined' && opts.endian === 'little') { | ||
if (opts !== undefined && opts.endian === 'little') { | ||
buf = reversebuf(buf); | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is false if
data.prevHash instanceof String
, whereas_.isString(new String('')) == true